WIP: Use global as root if available (for node) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I looked at this more closely and fixed it via: 7d223f5 This will run all the tests under node.js as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@searls - Can you advise on how to write a test for this? Looks like all your tests are running via lineman in a browser. Do we need to setup a separate grunt task that runs in node? Or is there a way we can fake "global" in the lineman spec? (Which, it seems like no, since that fake would have to be available at the time jasmine-stealth is loaded...)
Also, I can't get the tests to run in my fork (says "0/0"), but they run fine in the manta-frontend node_module instance.