-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mod] html grade change: values are V, C, Cjs, E #11
Conversation
V: Vanilla C: Customized Cjs: Customized including JS E: External See issue #6
html/main.js
Outdated
|
||
const HTML_GRADE_LABEL = { | ||
'V': 'Vanilla', | ||
'C': 'Customized, vanilla JS', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to write JavaScript
instead of JS
? I know this sounds stupid but not everyone knows that JS
means JavaScript
especially for the people that never programmed in their life.
html/main.js
Outdated
const HTML_GRADE_LABEL = { | ||
'V': 'Vanilla', | ||
'C': 'Customized, vanilla JS', | ||
'Cjs': 'Customized, including JS', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, here about JS
.
html/main.js
Outdated
'V': 'Vanilla', | ||
'C': 'Customized, vanilla JS', | ||
'Cjs': 'Customized, including JS', | ||
'E': 'External ressources', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo: it's resources
not ressources
.
html/main.js
Outdated
'Cjs': 'Customized, including JS', | ||
'E': 'External ressources', | ||
'?': 'Unknow', | ||
'js?': 'Unloaded script', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better to write JavaScript
instead of script
?
Is it supposed to be gray everywhere: https://searx.space/? |
@unixfox : nope |
fixed:
|
V: Vanilla
C: Customized
Cjs: Customized including JS
E: External
See issue #6