[mod] html grade change: values are V, C, Cjs, E #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V: Vanilla C: Customized Cjs: Customized including JS E: External See issue #6
unixfox
requested changes
Jan 13, 2020
html/main.js
Outdated
|
|
||
| const HTML_GRADE_LABEL = { | ||
| 'V': 'Vanilla', | ||
| 'C': 'Customized, vanilla JS', |
There was a problem hiding this comment.
Is it possible to write JavaScript instead of JS? I know this sounds stupid but not everyone knows that JS means JavaScript especially for the people that never programmed in their life.
html/main.js
Outdated
| const HTML_GRADE_LABEL = { | ||
| 'V': 'Vanilla', | ||
| 'C': 'Customized, vanilla JS', | ||
| 'Cjs': 'Customized, including JS', |
html/main.js
Outdated
| 'V': 'Vanilla', | ||
| 'C': 'Customized, vanilla JS', | ||
| 'Cjs': 'Customized, including JS', | ||
| 'E': 'External ressources', |
There was a problem hiding this comment.
Small typo: it's resources not ressources.
html/main.js
Outdated
| 'Cjs': 'Customized, including JS', | ||
| 'E': 'External ressources', | ||
| '?': 'Unknow', | ||
| 'js?': 'Unloaded script', |
There was a problem hiding this comment.
Probably better to write JavaScript instead of script?
|
Is it supposed to be gray everywhere: https://searx.space/? |
|
@unixfox : nope |
|
fixed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V: Vanilla
C: Customized
Cjs: Customized including JS
E: External
See issue #6