Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: azlyrics engine #3280

Closed
dalf opened this issue Mar 3, 2024 · 2 comments
Closed

Bug: azlyrics engine #3280

dalf opened this issue Mar 3, 2024 · 2 comments
Labels
area: engine bug Something isn't working

Comments

@dalf
Copy link
Member

dalf commented Mar 3, 2024

Engine broken on the master branch

A new x parameter is required.
@dalf dalf added bug Something isn't working area: engine labels Mar 3, 2024
return42 added a commit to return42/searxng that referenced this issue Mar 6, 2024
@return42
[fix] XPath engine azlyrics - new parameter x is needed.
4ef0a06 
This commit adds a static `x` argument to the GET URL.  Its not clear how long
this static value will work.  The alternative is to implement a python modul for
this engine to get the `x` argument from the HTML form of

https://search.azlyrics.com/search.php / the XPath selector to get the value is::

        //input[@name='x']@value

Closes: searxng#3280
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@return42 return42 mentioned this issue Mar 6, 2024
Closed
@return42
Copy link
Member

return42 commented Mar 6, 2024

Not sure the issue with the new argument (x) can be handled in a XPath engine .. in #3302 you will find a POC.

return42 added a commit to return42/searxng that referenced this issue Mar 6, 2024
@return42
[fix] XPath engine azlyrics - new parameter x is needed.
e7a16c1 
This commit adds a static `x` argument to the GET URL.  Its not clear how long
this static value will work.  The alternative is to implement a python modul for
this engine to get the `x` argument from the HTML form of

https://search.azlyrics.com/search.php / the XPath selector to get the value is::

        //input[@name='x']@value

Closes: searxng#3280
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42 added a commit to return42/searxng that referenced this issue Apr 27, 2024
@return42
[fix] drop broken azlyrics XPath engine
65bc9f6 
Unfortunately, azlyrics has a bot blocker that makes it impossible to implement
an XPath engine for it [1][2].

[1] searxng#3302 (comment)
[2] searxng#3280

Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@return42 return42 mentioned this issue Apr 27, 2024
Merged
@return42
Copy link
Member

return42 added a commit that referenced this issue Apr 27, 2024
@return42
[fix] drop broken azlyrics XPath engine
11fdc2f 
Unfortunately, azlyrics has a bot blocker that makes it impossible to implement
an XPath engine for it [1][2].

[1] #3302 (comment)
[2] #3280

Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: engine bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] XPath engine azlyrics - new parameter x is needed. return42/searxng
2 participants
@return42 @dalf