Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] XPath engine azlyrics - new parameter x is needed. #3302

Closed
wants to merge 1 commit into from

Conversation

return42
Copy link
Member

@return42 return42 commented Mar 6, 2024

This commit adds a static x argument to the GET URL. Its not clear how long this static value will work. The alternative is to implement a python modul for this engine to get the x argument from the HTML form of

https://search.azlyrics.com/search.php / the XPath selector to get the value is::

    //input[@name='x']@value

Closes: #3280

@return42 return42 mentioned this pull request Mar 6, 2024
This commit adds a static `x` argument to the GET URL.  Its not clear how long
this static value will work.  The alternative is to implement a python modul for
this engine to get the `x` argument from the HTML form of

https://search.azlyrics.com/search.php / the XPath selector to get the value is::

        //input[@name='x']@value

Closes: searxng#3280
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@Bnyro
Copy link
Member

Bnyro commented Mar 21, 2024

It unfortunately seems like the access token x you used in this PR is no longer valid, I'm always getting an empty result page in the browser and SearXNG with that token -> I think we should create a Python module instead, as you supposed above

return42 added a commit to return42/searxng that referenced this pull request Apr 27, 2024
Unfortunately, azlyrics has a bot blocker that makes it impossible to implement
an XPath engine for it [1][2].

[1] searxng#3302 (comment)
[2] searxng#3280

Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@return42
Copy link
Member Author

@return42 return42 closed this Apr 27, 2024
@return42 return42 deleted the fix-3280 branch April 27, 2024 16:41
return42 added a commit that referenced this pull request Apr 27, 2024
Unfortunately, azlyrics has a bot blocker that makes it impossible to implement
an XPath engine for it [1][2].

[1] #3302 (comment)
[2] #3280

Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: azlyrics engine
2 participants