Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media.ccc.de no video frame in standard videos #3431

Closed
cy8aer opened this issue Apr 27, 2024 · 1 comment · Fixed by #3432
Closed

media.ccc.de no video frame in standard videos #3431

cy8aer opened this issue Apr 27, 2024 · 1 comment · Fixed by #3432
Labels
bug Something isn't working

Comments

@cy8aer
Copy link
Contributor

cy8aer commented Apr 27, 2024 •
edited

Version of SearXNG, commit number if you are using on master branch and stipulate if you forked SearXNG

2024.4.27+1e1fb59be

How did you install SearXNG?

SearxNG ist installed via official docker container

What happened?

The new video frame does not work properly with the new frame functionality

How To Reproduce

  • Search !c3tv 37c3
  • Move to an official entry, like "37C3: Feierliche Eröffnung"
  • Click the "Open Video" Button

Expected behavior

The video frame is opened with the playable video in it

Screenshots & Logs

The video frame is opened empty and a .srt file is downloaded (here 37c3-12338-deu-eng-fra-37C3_Feierliche_Eroeffnung.de.srt)

Additional context

Unfortunately I did not find any video which opens in the frame

Standard configuration

  - name: media.ccc.de
    engine: ccc_media
    shortcut: c3tv
    # We don't set language: de here because media.ccc.de is not just
    # for a German audience. It contains many English videos and many
    # German videos have English subtitles.
    disabled: true
@cy8aer cy8aer added the bug Something isn't working label Apr 27, 2024
return42 added a commit to return42/searxng that referenced this issue Apr 27, 2024
@return42
[fix] ccc_media engine: filter video formats and ignore WebM
a3d7d23 
CCC media serves several recording formats, to name a few:

- application/x-subrip
- video/mp4
- video/webm
- audio/mpeg
- audio/opus
- audio/mpeg

not all of them are suitable for a video frame.  If available we should prefer
video/mp4 due to its minimal data rates.

Closes: searxng#3431
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
return42 added a commit to return42/searxng that referenced this issue Apr 27, 2024
@return42
[fix] ccc_media engine: filter video formats and ignore audio & SubRip
bcab8ec 
CCC media serves several recording formats, to name a few:

- application/x-subrip
- video/mp4
- video/webm
- audio/mpeg
- audio/opus
- audio/mpeg

not all of them are suitable for a video frame.  If available we should prefer
video/mp4 due to its minimal data rates.

Closes: searxng#3431
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
@return42 return42 mentioned this issue Apr 27, 2024
Merged
@return42
Copy link
Member

Thanks for pointing out 👍 .. its caused by the SubRip formats (links) we haven't filtered out / I send #3432 to fix this bug.

return42 added a commit that referenced this issue Apr 28, 2024
@return42
[fix] ccc_media engine: filter video formats and ignore audio & SubRip
e6c345f 
CCC media serves several recording formats, to name a few:

- application/x-subrip
- video/mp4
- video/webm
- audio/mpeg
- audio/opus
- audio/mpeg

not all of them are suitable for a video frame.  If available we should prefer
video/mp4 due to its minimal data rates.

Closes: #3431
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
VieuL pushed a commit to VieuL/searxng that referenced this issue Jul 5, 2024
@return42 @VieuL
[fix] ccc_media engine: filter video formats and ignore audio & SubRip
b0619e5 
CCC media serves several recording formats, to name a few:

- application/x-subrip
- video/mp4
- video/webm
- audio/mpeg
- audio/opus
- audio/mpeg

not all of them are suitable for a video frame.  If available we should prefer
video/mp4 due to its minimal data rates.

Closes: searxng#3431
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] ccc_media engine: filter video formats and ignore audio & SubRip return42/searxng
2 participants
@return42 @cy8aer