Add metadata and tags getters for items #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_getters_for_items
…_getters_for_items # Conflicts: # src/main/java/org/openhab/automation/jrule/items/JRuleItemClassGenerator.java # src/test/java/org/openhab/automation/jrule/items/JRuleCallGroupItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRuleCallItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRuleDateTimeGroupItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRuleDateTimeItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRuleQuantityGroupItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRuleQuantityItemTest.java
|
PUSH |
|
@querdenker2k must rebase/fix conflicts |
…_getters_for_items # Conflicts: # src/test/java/org/openhab/automation/jrule/rules/user/TestRules.java
|
conflicts resolved |
…_getters_for_items # Conflicts: # README.md # src/main/java/org/openhab/automation/jrule/internal/items/JRuleInternalContactItem.java # src/main/java/org/openhab/automation/jrule/internal/items/JRuleInternalRollershutterItem.java # src/main/java/org/openhab/automation/jrule/internal/items/JRuleInternalSwitchItem.java # src/test/resources/docker/conf/items/default.items
…r_items' into add_metadata_and_tags_getters_for_items # Conflicts: # README.md # src/test/resources/docker/conf/items/default.items
…_getters_for_items
|
@querdenker2k sorry for merging in the wrong order. Tried to resolve conflicts, but |
…_getters_for_items # Conflicts: # src/test/java/org/openhab/automation/jrule/items/JRuleCallGroupItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRuleColorGroupItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRuleContactGroupItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRuleDateTimeGroupItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRuleDimmerGroupItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRuleImageGroupItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRuleLocationGroupItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRuleNumberGroupItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRulePlayerGroupItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRuleQuantityGroupItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRuleRollershutterGroupItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRuleStringGroupItemTest.java # src/test/java/org/openhab/automation/jrule/items/JRuleSwitchGroupItemTest.java # src/test/java/org/openhab/binding/jrule/internal/triggers/itemchange/JRuleGroupItemChangeTest.java
…_getters_for_items # Conflicts: # README.md
seime
reviewed
Feb 23, 2023
seime
approved these changes
Feb 24, 2023
|
running this (and using), since a week in my production environment without errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add getTags for Item
add getMetadata for Item
add Javadoc for generated JRuleItems fields