add delayed execution, remove unused JRuleOr #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PUSH |
|
@querdenker2k must rebase/fix conflicts |
# Conflicts: # src/main/java/org/openhab/automation/jrule/internal/engine/JRuleEngine.java # src/main/java/org/openhab/automation/jrule/internal/engine/excutioncontext/JRuleItemExecutionContext.java # src/main/java/org/openhab/automation/jrule/internal/engine/excutioncontext/JRuleItemReceivedCommandExecutionContext.java # src/main/java/org/openhab/automation/jrule/internal/engine/excutioncontext/JRuleItemReceivedUpdateExecutionContext.java # src/test/java/org/openhab/automation/jrule/rules/user/TestRules.java
|
conflicts resolved |
|
The build failed once on my side. Not sure whether it is due to this PR or something introduced earlier: (infortunately I did not capture any stacktrace) I have a feeling something is wrong with the repeating timer. I have a few cases where cancellation of a repeating timer seem to fail (inconsistently), and the timer executes it's configured number of repeates. That might be related to failure of this testcase (intermittently) Do you have any insight @querdenker2k ? If it is unrelated to this PR, feel free to create a new issue instead. |
seime
approved these changes
Feb 12, 2023
|
i use repeating times in two rules and it seems that they work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UseCase: Do something when twilight is below 10lux + X minutes