Junit test for duplicate rule invocations #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes I think one event should trigger one execution |
|
And I agree should be triggered once. Possibly we could add something in the annotation to tell that it can trigger multiple times, but I don't see any personal need for it at least. |
seime
force-pushed
the
duplicate_invocation
branch
from
b37c042
to
a2e076e
Compare
seime
force-pushed
the
duplicate_invocation
branch
from
a2e076e
to
a939676
Compare
querdenker2k
reviewed
Nov 6, 2022
...t/java/org/openhab/binding/jrule/internal/rules/triggers/itemchange/JRuleItemChangeTest.java
Outdated
Show resolved
Hide resolved
querdenker2k
approved these changes
Nov 7, 2022
seime
force-pushed
the
duplicate_invocation
branch
from
a939676
to
454df8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails.
The test defines 2 overlapping JRuleWhen-conditions.
A single event is fired - which matches both conditions.
Currently we invoke the rule method twice.
I would argue a single invocation is correct, but this is not a bug but a design decision.
@querdenker2k @seaside1