feat: added fieldTypes prop to form #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a way to configure the input types through a Form prop. Signed-off-by: Julien Terzibaschian <julien@terzibaschian.com>
✅ Deploy Preview for remix-forms ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@danielweinmann could you please review this pr? I want it to get merged if everything is correct. |
danielweinmann
requested changes
Oct 24, 2023
There was a problem hiding this comment.
Hey, @ReptoxX! Thanks for the PR and sorry for the delay in reviewing it. It's looking real good! I just requested a few minor changes and we'll be good to go!
|
Hey @danielweinmann, Hope this works out. |
danielweinmann
requested changes
Oct 24, 2023
|
Okay i've resolved the conflict. |
danielweinmann
requested changes
Oct 26, 2023
There was a problem hiding this comment.
@ReptoxX, can you fix the broken tests? It looks like it's just a label that's incorrect.
danielweinmann
requested changes
Oct 26, 2023
danielweinmann
approved these changes
Oct 27, 2023
|
Thank you, @ReptoxX! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a way to configure the input types through a Form prop.
As mentioned in #217.