-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add undo_log.sql and add database driver class config #1323
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1323 +/- ##
=============================================
- Coverage 48.68% 48.65% -0.03%
Complexity 1643 1643
=============================================
Files 332 332
Lines 11517 11521 +4
Branches 1423 1424 +1
=============================================
- Hits 5607 5606 -1
- Misses 5291 5295 +4
- Partials 619 620 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix #1320 |
In fact, the server side does not need the undolog table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
core/src/main/java/io/seata/core/store/db/AbstractDataSourceGenerator.java
Outdated
Show resolved
Hide resolved
Yes.But it is a good idea to provide undo_log scripts on the server side. Because it will always be the same as the server version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i left a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
add a sql file when the first time to use seata . it is init to sql database and add database driver class name of config