-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: add table meta checker switch #1493
optimize: add table meta checker switch #1493
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1493 +/- ##
=============================================
+ Coverage 46.28% 46.42% +0.14%
- Complexity 1692 1693 +1
=============================================
Files 347 347
Lines 12691 12719 +28
Branches 1553 1591 +38
=============================================
+ Hits 5874 5905 +31
- Misses 6166 6173 +7
+ Partials 651 641 -10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…into config_schedule_table_meta_cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add this configuration item in nacos-config.txt
…into config_schedule_table_meta_cache
ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Configuring table meta checker is done. But I m wondering is it necessary configuring the TABLE_META_CHECKER_INTERVAL as well?
Ⅱ. Does this pull request fix one issue?
#1483
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews