Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: oracle batch insert error #1729

Merged
merged 10 commits into from
Oct 9, 2019
Merged

bugfix: oracle batch insert error #1729

merged 10 commits into from
Oct 9, 2019

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Oct 8, 2019

Ⅰ. Describe what this PR did

oracle batch insert error

Ⅱ. Does this pull request fix one issue?

fixes #1709

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #1729 into develop will decrease coverage by <.01%.
The diff coverage is 54.54%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1729      +/-   ##
=============================================
- Coverage       48.2%   48.19%   -0.01%     
- Complexity      1841     1846       +5     
=============================================
  Files            365      365              
  Lines          13279    13312      +33     
  Branches        1639     1645       +6     
=============================================
+ Hits            6401     6416      +15     
- Misses          6218     6233      +15     
- Partials         660      663       +3
Impacted Files Coverage Δ Complexity Δ
...o/seata/rm/datasource/AbstractConnectionProxy.java 11.7% <0%> (-1.4%) 6 <0> (ø)
.../rm/datasource/exec/BaseTransactionalExecutor.java 18.96% <100%> (+0.7%) 8 <1> (+1) ⬆️
...va/io/seata/rm/datasource/exec/InsertExecutor.java 69.69% <67.44%> (-0.94%) 41 <8> (+4)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 811a576...97a30f3. Read the comment docs.

@jsbxyyx jsbxyyx added the Do Not Merge Do not merge into develop label Oct 8, 2019
@jsbxyyx jsbxyyx removed the Do Not Merge Do not merge into develop label Oct 9, 2019
@slievrly slievrly self-requested a review October 9, 2019 09:41
Copy link
Contributor

@CoffeeLatte007 CoffeeLatte007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CoffeeLatte007 CoffeeLatte007 merged commit 59011ec into apache:develop Oct 9, 2019
dangquocbang pushed a commit to dangquocbang/seata that referenced this pull request Oct 14, 2019
* 'develop' of https://github.com/seata/seata:
  test: enhance test coverage of seata common (apache#1755)
  security: upgrade jackson to avoid security vulnerabilities (apache#1756)
  bugfix:rm channel register null resource (apache#1401)
  bugfix:fix memory lock is not released due to hash conflict (apache#1751)
  optimize:use raw types instead of boxing types (apache#1747)
  change get charset (apache#1707)
  fix undo support oracle table meta cache (apache#1749)
  bugfix: fix use 'in' and 'between' in where condition for Oracle and Mysql (apache#1699)
  optimize:add some server's jvm parameters (apache#1738)
  Saga implementation base on state machine (apache#1608)
  optimize:inner class may be static (apache#1706)
  feature: retry when tm commit or rollback failed (apache#1739)
  optimize: abstract common undolog manager method (apache#1712)
  bugfix: when tm commit or rollback failed,xid need to be clean (apache#1735)
  optimize: eliminate the possibility of allocating too much direct memory (apache#1657)
  Based on Java 5 optimization (apache#1705)
  bugfix: oracle batch insert error (apache#1729)

# Conflicts:
#	pom.xml
@wangliang181230 wangliang181230 added this to the 0.9.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hibernate batch insert report error
5 participants