-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: abstract table meta cache #1750
optimize: abstract table meta cache #1750
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1750 +/- ##
=============================================
+ Coverage 50.36% 50.57% +0.21%
- Complexity 2159 2166 +7
=============================================
Files 412 414 +2
Lines 14219 14192 -27
Branches 1714 1707 -7
=============================================
+ Hits 7161 7178 +17
+ Misses 6367 6324 -43
+ Partials 691 690 -1
Continue to review full report at Codecov.
|
…_abstract_table_cache # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/undo/AbstractUndoLogManager.java
…to feature_abstract_table_cache
rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/cache/AbstractTableMetaCache.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whether need add oracle meta cache test case
I don't know the oracle yet. I found it needs to be sorted out from the bug of pr1749. I'll learn later that can provide Oracle tests, but now I can provide TableMetaCacheFactoryTest. |
Sorry, I am not expressing it right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* 'develop' of https://github.com/seata/seata: feature:support gRpc (apache#1492) bugfix:fix auto proxy for multiple-datasource does not work (apache#1793) optimize: increase rm code coverage by db mock (apache#1674) bugfix: mysql can not get primary key value (apache#1788) bugfix: jdk 11 remoteAddress is null (apache#1764) test: verify that the analysis of the cause of issue 1702 is correct (apache#1710) optimize: seata server register eureka instance id (apache#1790) optimize: put message to logQueue (apache#1760) optimize:optimize rpc remoting log(apache#1787) optimize: simplify code (apache#1786) version: change version to 1.0.0-SNAPSHOT (apache#1785) bugfix: clean up resources in time to avoid mutual influence between unit tests (apache#1778) optimize:remove unused method (apache#1766) bugfix: DeleteExecutor. buildBeforeImageSQL keyword checker by db type (apache#1777) optimize: string splice and release lock (apache#1770) release 0.9.0 (apache#1771) bugfix: oracle rollback failed when the table has null Blob Clob value (apache#1761) bugfix: service method not support interface type parameter (apache#1759) optimize: abstract table meta cache (apache#1750) optimize: improve the efficiency of the batch log (apache#1743)
Ⅰ. Describe what this PR did
abstract table meta cache
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews