Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: oracle rollback failed when the table has null Blob Clob value #1761

Merged
merged 3 commits into from
Oct 14, 2019

Conversation

l81893521
Copy link
Contributor

@l81893521 l81893521 commented Oct 14, 2019

Ⅰ. Describe what this PR did

fix oracle rollback failed when the table that include null value in the Clob and Blob column

Ⅱ. Does this pull request fix one issue?

#1762

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Oct 14, 2019

Codecov Report

Merging #1761 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1761      +/-   ##
=============================================
- Coverage      50.57%   50.56%   -0.02%     
  Complexity      2166     2166              
=============================================
  Files            414      414              
  Lines          14192    14196       +4     
  Branches        1707     1709       +2     
=============================================
  Hits            7178     7178              
- Misses          6324     6328       +4     
  Partials         690      690
Impacted Files Coverage Δ Complexity Δ
...seata/rm/datasource/undo/AbstractUndoExecutor.java 75% <0%> (-2.78%) 21 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6afdf1e...47b26e8. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly
Copy link
Member

@l81893521 add issue.

@l81893521
Copy link
Contributor Author

@l81893521 add issue.

ok

@l81893521 l81893521 changed the title bugfix: fix oracle rollback failed bugfix: Oracle rollback failed when execute delete operate that has null Blob Clob value Oct 14, 2019
@slievrly slievrly changed the title bugfix: Oracle rollback failed when execute delete operate that has null Blob Clob value bugfix: oracle rollback failed when execute delete operate that has null Blob Clob value Oct 14, 2019
@l81893521 l81893521 changed the title bugfix: oracle rollback failed when execute delete operate that has null Blob Clob value bugfix: oracle rollback failed when table has null Blob Clob value Oct 14, 2019
@slievrly slievrly changed the title bugfix: oracle rollback failed when table has null Blob Clob value bugfix: oracle rollback failed when have null Blob Clob value Oct 14, 2019
@slievrly slievrly changed the title bugfix: oracle rollback failed when have null Blob Clob value bugfix: oracle rollback failed when have null Blob or Clob value Oct 14, 2019
@l81893521 l81893521 changed the title bugfix: oracle rollback failed when have null Blob or Clob value bugfix: oracle rollback failed when the table has null Blob Clob value Oct 14, 2019
@slievrly slievrly merged commit b8a39f8 into apache:develop Oct 14, 2019
dangquocbang pushed a commit to dangquocbang/seata that referenced this pull request Oct 22, 2019
* 'develop' of https://github.com/seata/seata:
  feature:support gRpc (apache#1492)
  bugfix:fix auto proxy for multiple-datasource does not work (apache#1793)
  optimize: increase rm code coverage by db mock (apache#1674)
  bugfix: mysql can not get primary key value (apache#1788)
  bugfix: jdk 11 remoteAddress is null (apache#1764)
  test: verify that the analysis of the cause of issue 1702 is correct (apache#1710)
  optimize: seata server register eureka instance id (apache#1790)
  optimize: put message to logQueue (apache#1760)
  optimize:optimize rpc remoting log(apache#1787)
  optimize: simplify code (apache#1786)
  version: change version to 1.0.0-SNAPSHOT (apache#1785)
  bugfix: clean up resources in time to avoid mutual influence between unit tests (apache#1778)
  optimize:remove unused method (apache#1766)
  bugfix: DeleteExecutor. buildBeforeImageSQL keyword checker by db type (apache#1777)
  optimize: string splice and release lock (apache#1770)
  release 0.9.0 (apache#1771)
  bugfix: oracle rollback failed when the table has null Blob Clob value (apache#1761)
  bugfix: service method not support interface type parameter (apache#1759)
  optimize: abstract table meta cache (apache#1750)
  optimize: improve the efficiency of the batch log (apache#1743)
@l81893521 l81893521 deleted the fix_oracle_rollback_fail branch November 2, 2019 05:30
@wangliang181230 wangliang181230 added this to the 0.9.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants