Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix register branch thread hang on tcc mode #1889

Merged
merged 2 commits into from
Nov 12, 2019
Merged

bugfix: fix register branch thread hang on tcc mode #1889

merged 2 commits into from
Nov 12, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Nov 12, 2019

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: fix register branch thread hang on tcc mode

Ⅱ. Does this pull request fix one issue?

fix #1888 #1862

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

#1401

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #1889 into develop will increase coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1889      +/-   ##
============================================
+ Coverage      55.22%   55.3%   +0.07%     
- Complexity      2381    2382       +1     
============================================
  Files            423     422       -1     
  Lines          14299   14282      -17     
  Branches        1700    1698       -2     
============================================
+ Hits            7897    7899       +2     
+ Misses          5687    5670      -17     
+ Partials         715     713       -2
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/seata/rm/tcc/TCCResourceManager.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...java/io/seata/rm/datasource/DataSourceManager.java 27.41% <ø> (-3.35%) 7 <0> (ø)
...main/java/io/seata/core/rpc/netty/RmRpcClient.java 31.86% <0%> (+3.15%) 10 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 58.54% <0%> (+1.58%) 30% <0%> (+1%) ⬆️

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx merged commit 0e9beb1 into apache:develop Nov 12, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thread hang on tcc mode
4 participants