-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:fix auto proxying of datasource which has final modifier #1996
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1996 +/- ##
=============================================
+ Coverage 55.25% 55.26% +0.01%
- Complexity 2430 2432 +2
=============================================
Files 432 432
Lines 14439 14442 +3
Branches 1706 1706
=============================================
+ Hits 7978 7982 +4
- Misses 5736 5738 +2
+ Partials 725 722 -3
|
spring/src/main/java/io/seata/spring/annotation/GlobalTransactionScanner.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
spring/src/main/java/io/seata/spring/annotation/GlobalTransactionScanner.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
When enable auto proxying of datasouce which has final modifier,it will cause a Exception means the class can't be proxied by using cglib.This PR will use JDK proxy instead of cglib to avoid this problem.
Ⅱ. Does this pull request fix one issue?
fixes #1995
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've done integration testing with following scenes:
1.Specific init-method for a datasource bean defination.
2.A datasource class that with final modifier.
3.A datasource that extends AbstractRoutingDataSource.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews