-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: added fst serialization #2418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2418 +/- ##
=============================================
+ Coverage 51.72% 51.75% +0.03%
- Complexity 2664 2699 +35
=============================================
Files 517 518 +1
Lines 16801 16793 -8
Branches 2031 2030 -1
=============================================
+ Hits 8690 8692 +2
+ Misses 7293 7290 -3
+ Partials 818 811 -7
|
slievrly
reviewed
Mar 17, 2020
serializer/seata-serializer-fst/src/test/java/io/seata/serializer/fst/KryoSerializerTest.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Mar 18, 2020
jsbxyyx
reviewed
Mar 19, 2020
core/src/main/java/io/seata/core/serializer/SerializerType.java
Outdated
Show resolved
Hide resolved
slievrly
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jsbxyyx
reviewed
Mar 20, 2020
serializer/seata-serializer-fst/src/main/java/io.seata.serializer.fst/FstSerializer.java
Show resolved
Hide resolved
jsbxyyx
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,optimize serializable class registry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
added fst serialization
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
transport.serialization=fst
Ⅴ. Special notes for reviews