-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: refactor client handle request process logic from server #2477
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2477 +/- ##
==========================================
Coverage 50.95% 50.95%
Complexity 2830 2830
==========================================
Files 563 563
Lines 18043 18043
Branches 2136 2136
==========================================
Hits 9193 9193
Misses 7980 7980
Partials 870 870 |
# Conflicts: # core/src/main/java/io/seata/core/rpc/netty/RpcClientBootstrap.java
core/src/main/java/io/seata/core/rpc/netty/processor/client/MergeResultMessageProcessor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/seata/core/rpc/netty/processor/client/RmHandleBranchRollbackProcessor.java
Outdated
Show resolved
Hide resolved
…/seata into refactoring-rpc-phase2
checkstyle |
ok. |
please check the test case: |
Unit tests are OK. |
core/src/main/java/io/seata/core/rpc/processor/client/RmBranchCommitProcessor.java
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/processor/client/RmBranchRollbackProcessor.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
core/src/main/java/io/seata/core/rpc/processor/client/ClientOnResponseProcessor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
ClientHeartbeatProcessor
ClientOnResponseProcessor
RmBranchCommitProcessor
RmBranchRollbackProcessor
RmUndoLogProcessor
ClientMessageSender
RegisterMsgListener
ClientMessageListener
Ⅱ. Does this pull request fix one issue?
refactoring tasks: #2313
III.Processor call flow.
server -> client
IV. TODO