-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve CONTRIBUTING docs #4163
Conversation
…. Add embedded script for 'git config' , 3. Improve case for 'github'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Please register the author and PR information in two 1.5.0.md files under the Changes folder
Codecov Report
@@ Coverage Diff @@
## develop #4163 +/- ##
=============================================
- Coverage 49.75% 49.42% -0.34%
+ Complexity 3767 3759 -8
=============================================
Files 700 700
Lines 23626 23626
Branches 2917 2918 +1
=============================================
- Hits 11755 11677 -78
- Misses 10671 10756 +85
+ Partials 1200 1193 -7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Improve CONTRIBUTING docs
Ⅱ. Does this pull request fix one issue?
NO, just improve docs.
Ⅲ. Why don't you add test cases (unit test/integration test)?
Unnecessary for docs.
Ⅳ. Describe how to verify it
See the change via any markdown reader
Ⅴ. Special notes for reviews