Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Awards - Add support for Google Cloud Storage backend for image uploads #37

Closed
markyjones opened this issue Mar 1, 2024 · 0 comments · Fixed by #38
Closed

Awards - Add support for Google Cloud Storage backend for image uploads #37

markyjones opened this issue Mar 1, 2024 · 0 comments · Fixed by #38

Comments

@markyjones
Copy link
Contributor

Add support for Google Cloud Storage backend for image uploads using @tweedegolf/sab-adapter-google-cloud.

We have a Pull Request ready if you are happy with this contribution?

Configuration would look like:

awards:
  storage:
    gcs:
      bucket: gs://backstage-awards # required
      keyFilename: path/to/keyFile.json # optional: defaults to GOOGLE_APPLICATION_CREDENTIALS
markyjones pushed a commit to markyjones/backstage-plugins that referenced this issue Mar 1, 2024
feat!(awards): add GCS storage for award logos (seatgeek#37)
352020e 
Award logos are now stored via GCS, s3 or local filesystem storage.
@colinodell colinodell linked a pull request Mar 1, 2024 that will close this issue
feat(awards): add GCS storage for award logos (#37) #38
Merged
markyjones pushed a commit to markyjones/backstage-plugins that referenced this issue Mar 1, 2024
feat!(awards): add GCS storage for award logos (seatgeek#37)
e8b64f8 
Award logos are now stored via GCS, s3 or local filesystem storage.
zhammer pushed a commit that referenced this issue Mar 1, 2024
@markyjones
feat(awards): add GCS storage for award logos (#37) (#38)
812bd52 
Award logos are now stored via GCS, s3 or local filesystem storage.

Co-authored-by: markjones <mark.x.jones@johnlewis.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(awards): add GCS storage for award logos (#37) markyjones/backstage-plugins
1 participant
@markyjones