Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(awards): add GCS storage for award logos (#37) #38

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

markyjones
Copy link
Contributor

Award logos are now stored via GCS, s3 or local filesystem storage.

awards:
  storage:
    gcs:
      bucket: gs://backstage-awards # required
      keyFilename: path/to/keyFile.json # optional: defaults to GOOGLE_APPLICATION_CREDENTIALS

Copy link
Collaborator

@colinodell colinodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Award logos are now stored via GCS, s3 or local filesystem storage.
@markyjones
Copy link
Contributor Author

markyjones commented Mar 1, 2024

Apologies - caught out by the linter. I have fixed the commit. @colinodell Might need to re-approve the Workflow if happy. 🙇

@zhammer zhammer merged commit 812bd52 into seatgeek:main Mar 1, 2024
9 checks passed
@zhammer
Copy link
Contributor

zhammer commented Mar 1, 2024

@markyjones going to merge this now and will cut a release. thanks for being the first non-seatgeek contributor to this project!

@zhammer zhammer changed the title feat!(awards): add GCS storage for award logos (#37) feat(awards): add GCS storage for award logos (#37) Mar 1, 2024
@zhammer
Copy link
Contributor

zhammer commented Mar 1, 2024

(renamed from feat! to feat type since ! suffix means a breaking change in semantic release)

Copy link

github-actions bot commented Mar 1, 2024

🎉 This PR is included in version 2.1.0 🎉

The release is available on @seatgeek/backstage-plugin-awards-backend@2.1.0

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on @seatgeek/backstage-plugin-gitlab-catalog-backend@1.0.0

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.0.2 🎉

The release is available on @seatgeek/backstage-plugin-slack-catalog-backend@1.0.2

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Awards - Add support for Google Cloud Storage backend for image uploads
3 participants