error in partial_ratio. closes #7

seatgeek · Dec 20, 2011 · 9d0912f · 9d0912f
1 parent 71d2838
commit 9d0912f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/fuzzywuzzy/fuzz.py b/fuzzywuzzy/fuzz.py
@@ -67,8 +67,7 @@ def partial_ratio(s1,  s2):
     #   best score === ratio("abcd", "Xbcd")
     scores = []
     for block in blocks:
-
-        long_start   = block[1] - block[0]
+        long_start   = block[1] - block[0] if (block[1] - block[0]) > 0 else 0
         long_end     = long_start + len(shorter)
         long_substr  = longer[long_start:long_end]
 

diff --git a/fuzzywuzzy/tests.py b/fuzzywuzzy/tests.py
@@ -24,7 +24,7 @@ def setUp(self):
             u"\xacCamarões assados",
             u"a\xac\u1234\u20ac\U00008000"
             ]
-        
+
 
     def tearDown(self):
         pass
@@ -109,6 +109,16 @@ def testWRatioMisorderedMatch(self):
         # misordered full matches are scaled by .95
         self.assertEqual(WRatio(self.s4, self.s5), 95)
 
+    def testIssueSeven(self):
+        s1 = "HSINCHUANG"
+        s2 = "SINJHUAN"
+        s3 = "LSINJHUANG DISTRIC"
+        s4 = "SINJHUANG DISTRICT"
+
+        self.assertGreater(partial_ratio(s1, s2), 75)
+        self.assertGreater(partial_ratio(s1, s3), 75)
+        self.assertGreater(partial_ratio(s1, s4), 75)
+
     # test processing methods
     def testGetBestChoice1(self):
         query = "new york mets at atlanta braves"