Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove featured members. Fixes #94 #136

Merged
merged 2 commits into from
Jul 27, 2016

Conversation

mjgiarlo
Copy link
Contributor

@mjgiarlo mjgiarlo commented Jul 20, 2016

YAGNI, apparently?

Also: ignore rvm/rbenv artifacts.

@@ -5,3 +5,4 @@ db/*.sqlite3
db/schema.rb
db/data.yml
config/memcache.conf
.ruby-gemset
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enough people coming to the project use gemsets that this is probably ok, but if I were you I'd set up a global gitignore in your git config and then you don't have to add things that aren't really project specific to every project you work on.

@phiggins
Copy link
Member

Seems good to me. 👍

Thanks!

@phiggins phiggins merged commit 3ad46ae into seattlerb:master Jul 27, 2016
@mjgiarlo mjgiarlo deleted the remove_featured_members_94 branch May 2, 2018 19:29
@seattlerb seattlerb locked and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants