Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change navbar collapse breakpoint, remove unused code and debug information #15

Conversation

miketierney
Copy link
Contributor

Especially for @zenspider: keep the navbar from collapsing at the tablet-level breakpoint.


Additionally:

  • remove the old bootstrap.css file (the Bootstrap code is compiled in to the seattlerb.css file)
  • remove debug info from generated CSS files

@phiggins
Copy link
Member

Is there a reason you're checking in the minified/compressed versions of assets? Seems unnecessary...

@miketierney
Copy link
Contributor Author

@phiggins Yeah it is deliberate, though I agree with you (see #16). Mostly I'm just playing nice with the current way that the repo is setup to handle deployment to Heroku (see https://devcenter.heroku.com/articles/rails-asset-pipeline; this is using the first option).

@zenspider
Copy link
Member

I'm so confused.

Why is this so fucking huge?

Why is bootstrap in seattlerb.css?

Where is the diff I care about?

@miketierney
Copy link
Contributor Author

Closing so I can create a cleaner change.

To answer @zenspider's questions:

  1. It's so huge because of the compiled assets in public/assets (see Remove checked-in public/assets #16)

  2. Bad decision on my part. This will be fixed.

  3. Coming later.

@seattlerb seattlerb locked and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants