Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Change navbar collapse breakpoint, remove unused code and debug information #15

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

miketierney commented Apr 10, 2013

Especially for @zenspider: keep the navbar from collapsing at the tablet-level breakpoint.


Additionally:

  • remove the old bootstrap.css file (the Bootstrap code is compiled in to the seattlerb.css file)
  • remove debug info from generated CSS files
Member

phiggins commented Apr 10, 2013

Is there a reason you're checking in the minified/compressed versions of assets? Seems unnecessary...

Contributor

miketierney commented Apr 10, 2013

@phiggins Yeah it is deliberate, though I agree with you (see #16). Mostly I'm just playing nice with the current way that the repo is setup to handle deployment to Heroku (see https://devcenter.heroku.com/articles/rails-asset-pipeline; this is using the first option).

Owner

zenspider commented Apr 10, 2013

I'm so confused.

Why is this so fucking huge?

Why is bootstrap in seattlerb.css?

Where is the diff I care about?

Contributor

miketierney commented Apr 10, 2013

Closing so I can create a cleaner change.

To answer @zenspider's questions:

  1. It's so huge because of the compiled assets in public/assets (see #16)

  2. Bad decision on my part. This will be fixed.

  3. Coming later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment