Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal #21

Closed
13 tasks
hjalmers opened this issue Apr 24, 2019 · 4 comments
Closed
13 tasks

Modal #21

hjalmers opened this issue Apr 24, 2019 · 4 comments

Comments

@hjalmers
Copy link
Contributor

hjalmers commented Apr 24, 2019

First version:

  • Basic modal component and service?
  • Modal should be added to body
  • Use bootstrap class names and markup by default
  • Add/remove class to body when modal is shown/hidden
  • Use body-scroll-lock to prevent background scroll on mobile devices
  • Ability to pass modal type (aside, fullscreen etc).
  • Ability to toggle close button in upper right corner next to heading
  • Ability to pass text for heading, body
  • Ability to pass array with buttons to be rendered in footer
  • Ability to pass custom template
  • Ability to pass size (sm, md, lg)?
  • Ability to pass custom container if modal shouldn't attach to body
  • Add a query string when popup opens, to be able to add a page into browser history and back btn naturally closes the popup.
@hjalmers
Copy link
Contributor Author

@dahllen since you had an embryo for a first version I think it would be a good start to add that one:)

@hjalmers
Copy link
Contributor Author

hjalmers commented May 3, 2019

@omarVodiaK and @dahllen perhaps you could have a small work meeting prior to next weeks Front X meeting and just discuss and sync the work with the modal since I know you both have done some work already, and share your thoughts and ideas with the rest of the group?

@yousifalraheem
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sebopensource
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants