Use stderr instead of stdout if stdout is not a TTY #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the default behavior before prompt-toolkit/python-prompt-toolkit@2c96fe2 switched the default behavior to output plain text instead. Since we're showing a menu and requiring selection, using stderr as fallback is preferred to outputting plain text to stdout. This enables use-cases where the main command's output gets piped to a pager, with the selection necessary for generating that output still working.
MasterofJOKers
force-pushed
the
prompt-toolkit-always-prefer-tty
branch
from
0684e49
to
4537b71
Compare
sebageek
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the default behavior before
prompt-toolkit/python-prompt-toolkit@2c96fe2
switched the default behavior to output plain text instead. Since we're
showing a menu and requiring selection, using stderr as fallback is
preferred to outputting plain text to stdout. This enables use-cases
where the main command's output gets piped to a pager, with the
selection necessary for generating that output still working.