Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated version of mocha and nock for following projects #2

Merged
merged 3 commits into from
Jul 24, 2014

Conversation

pvoznenko
Copy link
Contributor

Since unit test was failing with following error message:

% npm test                                                                                                                                          ~/Projects/bamboo-api:master

> bamboo-api@0.0.2 test /Users/pavlo/Projects/bamboo-api
> mocha


  ․․․․․․․․․․․․․․․․․

  ✖ 6 of 18 tests failed:

  1) bamboo.getLatestSuccessfulBuilNumber returns the latest successful build number:
     TypeError: Cannot read property 'readable' of undefined
      at IncomingMessage._read (http.js:347:18)
      at IncomingMessage.Readable.read (_stream_readable.js:320:10)
      at IncomingMessage.read (http.js:339:15)
      at IncomingMessage.<anonymous> (_stream_readable.js:744:45)
      at IncomingMessage.EventEmitter.emit (events.js:92:17)
      at emitDataEvents (_stream_readable.js:770:10)
      at IncomingMessage.Readable.on (_stream_readable.js:691:5)
      at OverridenClientRequest.<anonymous> (/Users/pavlo/Projects/bamboo-api/node_modules/request/main.js:611:16)
      at OverridenClientRequest.EventEmitter.emit (events.js:95:17)
      at /Users/pavlo/Projects/bamboo-api/node_modules/nock/lib/request_overrider.js:220:11
      at process._tickCallback (node.js:419:13)
      at Function.Module.runMain (module.js:499:11)
      at startup (node.js:119:16)
      at node.js:906:3

  2) bamboo.getBuildStatus returns the build Status:
     TypeError: Cannot read property 'readable' of undefined
      at IncomingMessage._read (http.js:347:18)
      at IncomingMessage.Readable.read (_stream_readable.js:320:10)
      at IncomingMessage.read (http.js:339:15)
      at IncomingMessage.<anonymous> (_stream_readable.js:744:45)
      at IncomingMessage.EventEmitter.emit (events.js:92:17)
      at emitDataEvents (_stream_readable.js:770:10)
      at IncomingMessage.Readable.on (_stream_readable.js:691:5)
      at OverridenClientRequest.<anonymous> (/Users/pavlo/Projects/bamboo-api/node_modules/request/main.js:611:16)
      at OverridenClientRequest.EventEmitter.emit (events.js:95:17)
      at /Users/pavlo/Projects/bamboo-api/node_modules/nock/lib/request_overrider.js:220:11
      at process._tickCallback (node.js:419:13)
      at process._tickFromSpinner (node.js:394:15)

  3) bamboo.getAllPlans returns a list of all plans available:
     TypeError: Cannot read property 'readable' of undefined
      at IncomingMessage._read (http.js:347:18)
      at IncomingMessage.Readable.read (_stream_readable.js:320:10)
      at IncomingMessage.read (http.js:339:15)
      at IncomingMessage.<anonymous> (_stream_readable.js:744:45)
      at IncomingMessage.EventEmitter.emit (events.js:92:17)
      at emitDataEvents (_stream_readable.js:770:10)
      at IncomingMessage.Readable.on (_stream_readable.js:691:5)
      at OverridenClientRequest.<anonymous> (/Users/pavlo/Projects/bamboo-api/node_modules/request/main.js:611:16)
      at OverridenClientRequest.EventEmitter.emit (events.js:95:17)
      at /Users/pavlo/Projects/bamboo-api/node_modules/nock/lib/request_overrider.js:220:11
      at process._tickCallback (node.js:419:13)

  4) bamboo.getLatestSuccessfulBuilNumber returns a msg when the plan doesn't contain any successful build:
     TypeError: Cannot read property 'readable' of undefined
      at IncomingMessage._read (http.js:347:18)
      at IncomingMessage.Readable.read (_stream_readable.js:320:10)
      at IncomingMessage.read (http.js:339:15)
      at IncomingMessage.<anonymous> (_stream_readable.js:744:45)
      at IncomingMessage.EventEmitter.emit (events.js:92:17)
      at emitDataEvents (_stream_readable.js:770:10)
      at IncomingMessage.Readable.on (_stream_readable.js:691:5)
      at OverridenClientRequest.<anonymous> (/Users/pavlo/Projects/bamboo-api/node_modules/request/main.js:611:16)
      at OverridenClientRequest.EventEmitter.emit (events.js:95:17)
      at /Users/pavlo/Projects/bamboo-api/node_modules/nock/lib/request_overrider.js:220:11
      at process._tickCallback (node.js:419:13)

  5) bamboo.getAllPlans returns a string saying that there are no plans:
     TypeError: Cannot read property 'readable' of undefined
      at IncomingMessage._read (http.js:347:18)
      at IncomingMessage.Readable.read (_stream_readable.js:320:10)
      at IncomingMessage.read (http.js:339:15)
      at IncomingMessage.<anonymous> (_stream_readable.js:744:45)
      at IncomingMessage.EventEmitter.emit (events.js:92:17)
      at emitDataEvents (_stream_readable.js:770:10)
      at IncomingMessage.Readable.on (_stream_readable.js:691:5)
      at OverridenClientRequest.<anonymous> (/Users/pavlo/Projects/bamboo-api/node_modules/request/main.js:611:16)
      at OverridenClientRequest.EventEmitter.emit (events.js:95:17)
      at /Users/pavlo/Projects/bamboo-api/node_modules/nock/lib/request_overrider.js:220:11
      at process._tickCallback (node.js:419:13)

  6) bamboo.getAllPlans returns a string saying that there are no plans:
     TypeError: Cannot read property 'readable' of undefined
      at IncomingMessage._read (http.js:347:18)
      at IncomingMessage.Readable.read (_stream_readable.js:320:10)
      at IncomingMessage.read (http.js:339:15)
      at IncomingMessage.<anonymous> (_stream_readable.js:744:45)
      at IncomingMessage.EventEmitter.emit (events.js:92:17)
      at emitDataEvents (_stream_readable.js:770:10)
      at IncomingMessage.Readable.on (_stream_readable.js:691:5)
      at OverridenClientRequest.<anonymous> (/Users/pavlo/Projects/bamboo-api/node_modules/request/main.js:611:16)
      at OverridenClientRequest.EventEmitter.emit (events.js:95:17)
      at /Users/pavlo/Projects/bamboo-api/node_modules/nock/lib/request_overrider.js:220:11
      at process._tickCallback (node.js:419:13)


npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0

Found that is bug in old version of module 'nock': nock/nock#146

So updated version of mocha and nock, should fix issues with tests.

@pvoznenko
Copy link
Contributor Author

with second commit added possibility for basic http authentication. updated test.

@pvoznenko
Copy link
Contributor Author

with third commit: updated README to cover topic regarding basic http authentication

@pvoznenko
Copy link
Contributor Author

Could you please also update version for NPM if you approve my pull request of course :)?
So I can use it without hack in my project :) Thanks!

@sebarmeli
Copy link
Owner

Thanks!

sebarmeli added a commit that referenced this pull request Jul 24, 2014
updated version of mocha and nock for following projects
@sebarmeli sebarmeli merged commit 942c5a1 into sebarmeli:master Jul 24, 2014
@pvoznenko
Copy link
Contributor Author

Thanks! Could you also please update version at NPM?
For updating NPM, checkout this repo to you computer, then change version at 'package.json' to '0.0.3' and run command 'npm publish'.

Thanks again, I hope I will contribute few times more :) have a nice day!

@sebarmeli
Copy link
Owner

yeah I know how to update a package..hehe..done now.

sorry for the delay, I'm so busy at the moment

@pvoznenko
Copy link
Contributor Author

Thanks man. Sorry for disturbing, I thought there might be something on a way :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants