Add syntax highlighting to singular kernel #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a codemirror "SimpleMode" to singular kernel Modify setup.py (previous version doesn't remove installed files under local/share/jupyter/kernels)
|
Thanks a lot :). I will review the PR this weekend and merge it asap :). |
|
I merged your changes and acknowledged them in the |
|
Thanks. I am fine with the acknowledgment. |
|
All right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a codemirror "SimpleMode" to singular kernel
Modify setup.py (previous version doesn't remove installed files under
local/share/jupyter/kernels)
Linked to OpenDreamkit issue #175
@sebasguts
I used mainly this resource https://www.singular.uni-kl.de/Manual/latest/index.htm as base to do this syntax highlight.
Please tell me if it looks up to date for you and if i am missing something important with the
singular syntax.
About type tokens i set them to the "qualifier" kind of token, because "type" kind of token doesn't have a
css style applied with jupyter.