Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more lobby and safe area stage IDs #307

Closed

Conversation

alborrajo
Copy link
Collaborator

Checklist:

  • The project compiles
  • The PR targets develop branch

@alborrajo alborrajo marked this pull request as draft May 11, 2024 12:21
2 // White Dragon Temple
// Lobbies
2, // White Dragon Temple
3, // Audience Chamber
Copy link
Collaborator

@pacampbell pacampbell May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice when looking at some packets, we can see these as well in the S2C_STAGE_AREA_CHANGE_PACKET. The IsBase field gets set to true.

WDT

{"StageNo": 2, "IsBase": true, "StageFeatureList": [{"Value": 1001}, {"Value": 2001}], "Unk0": [], "Unk1": [], "Error": 0, "Result": 0}}

Audience Chamber

{"Structure": {"StageNo": 3, "IsBase": true, "StageFeatureList": [{"Value": 1001}, {"Value": 2001}], "Unk0": [], "Unk1": [], "Error": 0, "Result": 0}}

Hallow of Beginnings: Gathering Area

{"Structure": {"StageNo": 384, "IsBase": true, "StageFeatureList": [], "Unk0": [], "Unk1": [], "Error": 0, "Result": 0}}

Glyndwr Centrum

{"StageNo": 377, "IsBase": true, "StageFeatureList": [{"Value": 1001}, {"Value": 2008}], "Unk0": [], "Unk1": [], "Error": 0, "Result": 0}}

Lookout Castle

{"StageNo": 478, "IsBase": true, "StageFeatureList": [{"Value": 1003}, {"Value": 2009}], "Unk0": [], "Unk1": [], "Error": 0, "Result": 0}}

Firefall Mountain Camp

{"StageNo": 595, "IsBase": true, "StageFeatureList": [], "Unk0": [], "Unk1": [], "Error": 0, "Result": 0}}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this into some common area which it can be queried? In the quest branch, I made a StageManager class which would probably be a good place for this kind of information.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea. If you're merging this into your quest branch then i'll close my PR

@alborrajo
Copy link
Collaborator Author

Obsolete since PR #354 is merged

@alborrajo alborrajo closed this Jun 21, 2024
@alborrajo alborrajo deleted the feature/lobbysafeareas branch June 21, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants