Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more safe areas to StageAreaChangeHandler.cs #354

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Added more safe areas to StageAreaChangeHandler.cs #354

merged 3 commits into from
Jun 21, 2024

Conversation

Abiel-Machioni
Copy link
Contributor

@Abiel-Machioni Abiel-Machioni commented Jun 19, 2024 •
edited
Loading

  • Added more safe areas where reset NTC is sent.
  • S2C_INSTANCE_AREA_RESET_NTC gets sent every time you zone in a safe area, meaning, when inside The White Dragon Temple, it'll happen a lot more, i don't know if this is a problem, if it is, i can remove the areas inside The White Dragon Temple until resolved.

Checklist:

  • The project compiles
  • The PR targets develop branch

@Abiel-Machioni
Update StageAreaChangeHandler.cs
11c1d88 
- Added more safe areas where reset NTC is sent.
@Abiel-Machioni Abiel-Machioni changed the title Update StageAreaChangeHandler.cs Added more safe areas to StageAreaChangeHandler.cs Jun 19, 2024
@pacampbell
Copy link
Collaborator

There is a class called the stage manager I recently added. Can we add a function which can check these ID's in that file instead?

pacampbell
pacampbell reviewed Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@pacampbell pacampbell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alborrajo Can you review since I provided the patch? :)

alborrajo
alborrajo approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@alborrajo alborrajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this makes PR #307 obsolete. Looks good to me

@alborrajo alborrajo merged commit 35a8526 into sebastian-heinz:develop Jun 21, 2024
1 check passed
@alborrajo alborrajo mentioned this pull request Jun 21, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacampbell pacampbell pacampbell left review comments

@alborrajo alborrajo alborrajo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Abiel-Machioni @pacampbell @alborrajo