Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the contents of the Constraints table #64

Closed
lex111 opened this issue May 28, 2018 · 4 comments
Closed

Simplify the contents of the Constraints table #64

lex111 opened this issue May 28, 2018 · 4 comments

Comments

@lex111
Copy link
Contributor

lex111 commented May 28, 2018

I suggest removing the substring "it is evaluated for" from the following table, because it complicates the general sentence.

Is it not better, compare:

Before After
Constraint that asserts that the value it is evaluated for is greater than a given value. Constraint that asserts that the value is greater than a given value.

Currently some lines of this table do not contain this substring (Constraint that accepts any input value.)

@sebastianbergmann what do you think about this?

@sebastianbergmann
Copy link
Owner

Makes sense.

@keradus
Copy link
Contributor

keradus commented May 29, 2018

#65 is merged already, this issue shall be closed

I assume that you are doing cherry picking instead of regular merges @sebastianbergmann ? for that, github won't automatically close issues for you

@lex111
Copy link
Contributor Author

lex111 commented May 29, 2018

Hmm, strange, it should have closed itself after accepting PR.

@lex111 lex111 closed this as completed May 29, 2018
@keradus
Copy link
Contributor

keradus commented May 29, 2018

it was merged to 7.1 branch, while main branch is master.
ticket would be autoclosed only if info about merge to 7.1 would remain in merge of 7.1 into master (which can be done, but it's only an option, it's not always there - depends how syncing was made)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants