Show @testdox empty string parameters as '' when color is off

sebastianbergmann · Dec 14, 2018 · 36c29e8 · 36c29e8
1 parent 7a9745b
commit 36c29e8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/Util/TestDox/NamePrettifier.php b/src/Util/TestDox/NamePrettifier.php
@@ -215,7 +215,11 @@ private function mapTestMethodParameterNamesToProvidedDataValues(TestCase $test)
             }
 
             if (\is_string($value) && $value === '') {
-                $value = Color::colorize('underlined', 'empty');
+                if ($this->useColor) {
+                    $value = Color::colorize('dim,underlined', 'empty');
+                } else {
+                    $value = "''";
+                }
             }
 
             $providedData['$' . $parameter->getName()] = $value;

diff --git a/tests/_files/raw_output_ColorTest.txt b/tests/_files/raw_output_ColorTest.txt
@@ -7,10 +7,10 @@ Runtime:       %s
  [32m✔[0m Colorize with [36mone[2m·[22mcolor[0m [32m %f ms[0m
  [32m✔[0m Colorize with [36mmultiple[2m·[22mcolors[0m [32m %f ms[0m
  [32m✔[0m Colorize path [36m%ephp%eunit%etest.phpt[0m after [36mNULL[0m [32m %f ms[0m
- [32m✔[0m Colorize path [36m%ephp%eunit%etest.phpt[0m after [36m[4mempty[0m[0m [32m %f ms[0m
+ [32m✔[0m Colorize path [36m%ephp%eunit%etest.phpt[0m after [36m[2;4mempty[0m[0m [32m %f ms[0m
  [32m✔[0m Colorize path [36m%ephp%eunit%etest.phpt[0m after [36m%e[0m [32m %f ms[0m
  [32m✔[0m Colorize path [36m%ephp%eunit%etest.phpt[0m after [36m%ephp%e[0m [32m %f ms[0m
- [32m✔[0m Colorize path [36m%e_d-i.r%et-e_s.t.phpt[0m after [36m[4mempty[0m[0m [32m %f ms[0m
+ [32m✔[0m Colorize path [36m%e_d-i.r%et-e_s.t.phpt[0m after [36m[2;4mempty[0m[0m [32m %f ms[0m
  [32m✔[0m dim($m) and colorize('dim',$m) return different ANSI codes [32m %f ms[0m
  [32m✔[0m Visualize all whitespace characters in [36mno-spaces[0m [32m %f ms[0m
  [32m✔[0m Visualize all whitespace characters in [36m[2m·[22mspace[2m···[22minvaders[2m·[22m[0m [32m %s ms[0m