Improve comparison of DOMNode objects

sebastianbergmann · Apr 23, 2014 · 7dadedf · 7dadedf
1 parent 6a604dd
commit 7dadedf
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/Framework/Comparator/DOMNode.php b/src/Framework/Comparator/DOMNode.php
@@ -85,15 +85,15 @@ public function accepts($expected, $actual)
      */
     public function assertEquals($expected, $actual, $delta = 0.0, $canonicalize = false, $ignoreCase = false)
     {
-        $expectedXML = $expected->C14N();
-        $actualXML   = $actual->C14N();
+        $expectedAsString = $this->domToText($expected);
+        $actualAsString   = $this->domToText($actual);
 
         if ($ignoreCase === true) {
-            $expectedXML = strtolower($expectedXML);
-            $actualXML   = strtolower($actualXML);
+            $expectedAsString = strtolower($expectedAsString);
+            $actualAsString   = strtolower($actualAsString);
         }
 
-        if ($expectedXML !== $actualXML) {
+        if ($expectedAsString !== $actualAsString) {
             if ($expected instanceof DOMDocument) {
                 $type = 'documents';
             } else {
@@ -103,8 +103,8 @@ public function assertEquals($expected, $actual, $delta = 0.0, $canonicalize = f
             throw new PHPUnit_Framework_ComparisonFailure(
               $expected,
               $actual,
-              $this->domToText($expected),
-              $this->domToText($actual),
+              $expectedAsString,
+              $actualAsString,
               false,
               sprintf('Failed asserting that two DOM %s are equal.', $type)
             );