Tidy up.

sebastianbergmann · Sep 24, 2006 · d56c71e · d56c71e
1 parent 6028e1b
commit d56c71e
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/PHPUnit/Framework/TestSuite.php b/PHPUnit/Framework/TestSuite.php
@@ -179,12 +179,12 @@ public function __construct($theClass = '', $name = '')
 
         $constructor = $theClass->getConstructor();
 
-        if ($constructor === NULL ||
+        if ($constructor !== NULL &&
             !$constructor->isPublic()) {
             $this->addTest(
               self::warning(
                 sprintf(
-                  'Class %s has no public constructor',
+                  'Class "%s" has no public constructor.',
 
                   $theClass->getName()
                 )
@@ -204,7 +204,7 @@ public function __construct($theClass = '', $name = '')
             $this->addTest(
               self::warning(
                 sprintf(
-                  'No tests found in %s',
+                  'No tests found in class "%s".',
 
                   $theClass->getName()
                 )
@@ -333,7 +333,9 @@ public function addTestFile($filename)
 
         if (!$testsFound) {
             $this->addTest(
-              new PHPUnit_Framework_Warning('No tests found in file ' . $filename)
+              new PHPUnit_Framework_Warning(
+                'No tests found in file "' . $filename . '".'
+              )
             );
         }
 
@@ -388,7 +390,7 @@ public static function createTest(ReflectionClass $theClass, $name)
         if (!$theClass->isInstantiable()) {
             return self::warning(
               sprintf(
-                'Cannot instantiate test case %s.',
+                'Cannot instantiate class "%s".',
                 $theClass->getName()
               )
             );
@@ -415,7 +417,7 @@ public static function createTest(ReflectionClass $theClass, $name)
             else {
                 return self::warning(
                   sprintf(
-                    'Constructor of class %s is not TestCase($name) or TestCase().',
+                    'Constructor of class "%s" is not TestCase($name) or TestCase().',
                     $theClass->getName()
                   )
                 );
@@ -577,7 +579,7 @@ private function addTestMethod(ReflectionMethod $method, Array &$names, Reflecti
             $this->addTest(
               self::warning(
                 sprintf(
-                  'Test method is not public: %s',
+                  'Test method "%s" is not public.',
 
                   $name
                 )