Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage text do not honor --colors setting #1892

Closed
mgansler opened this issue Oct 3, 2015 · 3 comments
Closed

coverage text do not honor --colors setting #1892

mgansler opened this issue Oct 3, 2015 · 3 comments
Labels
type/bug Something is broken

Comments

@mgansler
Copy link

mgansler commented Oct 3, 2015

Issue #1771 still exists with PHPUnit 4.8.10 as well as with 5.0.3

--coverage-text shows colors even when --colors=never is used.

@sebastianbergmann sebastianbergmann added the type/bug Something is broken label Oct 4, 2015
@sebastianbergmann
Copy link
Owner

Since I neither use --colors nor --coverage-text myself it is unlikely that I will work on a fix for this myself. I would review and then merge a pull request that fixes this, of course.

@llaville
Copy link

@sebastianbergmann I'm sorry to tell you that PHPUnit 4.8.13 is still affected by this issue (not fixed)

https://github.com/sebastianbergmann/phpunit/blob/4.8/src/TextUI/TestRunner.php#L506-L513

@sebastianbergmann
Copy link
Owner

Nothing to be sorry about. The fix has not been backported / cherry-picked to 4.8 yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is broken
Projects
None yet
Development

No branches or pull requests

3 participants