-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing failure message when assertFileNotEquals() is used on two empty files #2721
Comments
If both files are empty the |
It's not about empty files. This happen for same-content files as well. I don't now what is the issue is. |
I might be wrong here but I think there is no issue, A nice improvement might be to fail as;
|
This is WTF to me. How do I know what "string:a" is? I didn't event notice the "a" there. I would expect this message: $this->assertNotEquals('a', 'a');
Failed asserting that 'a' is not equal to 'a'. To be consistent with the rest of PHPUnit messages. $this->assertContains('a', $value);
// Failed $value ... contains 'a'. # pseudo message, not sure what exactly is there And not: // Failed $value ... contains '<string:a>'. # pseudo message, not sure what exactly is there
Yes. With their content possible, I'd have to look for the real differences manually to the files otherwise. |
ah now I see :) 👍 |
I just looked at this (sorry for not looking at it sooner) and I am confused as to what this is about. |
There is nothing wrong.
which is fine, but confusing for some users. |
Can we make it less confusing? |
…ergmann#2721 Matched pattern to negat-Functionality
Matched pattern to negat-Functionality
Awesome, thank you all |
Works fine.
But...
shows
Not sure what that means. At the moment I use workaround:
The text was updated successfully, but these errors were encountered: