-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitelist for PHAR Scoping #3750
Comments
|
While investigating whether |
It seems that
The rest I assumed is public API, but prefixing it based on internal or not would be nice. |
Thank you, @sebastianfeldmann for your feedback. I removed |
Interestingly enough I was able to remove both I have not committed these changes yet as I want to test them a little further. |
All my tests so far indicate that |
Since CodeCoverage and PHP_Token are not part of the public API of PHPUnit they can safely be removed from the whitelist. Issue sebastianbergmann#3750
Since CodeCoverage and PHP_Token are not part of the public API of PHPUnit they can safely be removed from the whitelist. Issue sebastianbergmann#3750
Since CodeCoverage and PHP_Token are not part of the public API of PHPUnit they can safely be removed from the whitelist. Issue #3750
Currently, we exclude
PHPUnit\*
,SebastianBergmann\CodeCoverage\*
,PharIo\*
,PHP_Token*
,Prophecy\*
,from the prefixing of all code bundled in PHAR distribution with random/unique namespace.
I would like to reduce the amount of code that does not get prefixed.
When it comes to
PHPUnit\*
, only classes, interfaces, and traits that are not annotated with@internal
should be excluded. I will investigate whether this works by manually creating a list of these code units. In the long run, it would be great if php-scoper supported this natively.I am not sure why
SebastianBergmann\CodeCoverage\*
,PharIo\*
, andPHP_Token*
are excluded. Maybe @sebastianfeldmann can provide some insight here? ExcludingPharIo\*
, for instance, means that @theseer and @sebastianheuer cannot use the scopedphpunit.phar
for testing theirPharIo
code as intended.With regard to
Prophecy\*
I am sure that some classes, interfaces, or traits of Prophecy need to be excluded (so that code complete and/our type annotations in test code continue to work).The text was updated successfully, but these errors were encountered: