Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: serialization of test suits static properties #1208

Closed
wants to merge 4 commits into from
Closed

Fix: serialization of test suits static properties #1208

wants to merge 4 commits into from

Commits on Mar 27, 2014

  1. Fix: serialization of test suits static properties 

    When --backupStaticAttributes switch is set static properties of classes derived from PHPUnit_Framework_Test are also backed up due to wrong use of instanceof.

<string> instanceof <object>|<class>|<string> is always false. One should use is_a(<stringClassName>, <stringClassName>, true).

This bug affect all versions of PHPUnit that uses PHPUnit_Util_GlobalState class.
    @majkel89
    majkel89 committed Mar 27, 2014
    Copy the full SHA
    6b0c7fc View commit details
    Browse the repository at this point in the history

  2. fixed compatibility issue with PHP 5.3.3 

    is_a in PHP 5.3.3 does not support third parameter (allow_string) thus $object parameter cannot be string.
    @majkel89
    majkel89 committed Mar 27, 2014
    Copy the full SHA
    c5f8c53 View commit details
    Browse the repository at this point in the history

  3. +++ test of test case static property preservation

    @majkel89
    majkel89 committed Mar 27, 2014
    Copy the full SHA
    ac8d100 View commit details
    Browse the repository at this point in the history

  4. typo fix

    @majkel89
    majkel89 committed Mar 27, 2014
    Copy the full SHA
    2aded42 View commit details
    Browse the repository at this point in the history