add File and Directory constraints and assertions #2262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble, and DirectoryExists, with convenience assertions to ensure that files and directories are or are not readable and writable.
sebastianbergmann
added
the
type/enhancement
|
Thank you for your contribution. I am considering merging this for PHPUnit 5.6. Can you please open a pull request for https://github.com/sebastianbergmann/phpunit-documentation that documents these new assertions? |
|
@sebastianbergmann thanks for making projects that are so easy to build and in which to contribute : ) here are the new docs: sebastianbergmann/phpunit-documentation#382 please let me know if i have missed anything, or if it looks out of sorts. |
|
@sebastianbergmann Thanks for the efforts |
|
Merged manually, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add Constraints:
add Assertions:
added tests to completely cover the constraints, and tests to cover most of the assertions... however it will be difficult/impossible to completely test some of the assertions without using a virtual filesystem. how do you feel about my inclusion of
mikey179/vfsStreamor a similar package for this purpose?