Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings to JUnit report - closes #3793 #3910

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Add warnings to JUnit report - closes #3793 #3910

merged 2 commits into from
Oct 28, 2019

Conversation

DanielRuf
Copy link
Contributor

This should properly add the warnings to the output of the JUnit log, see #3793.

@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #3910 into 8.4 will increase coverage by 1.18%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                8.4    #3910      +/-   ##
============================================
+ Coverage     83.68%   84.86%   +1.18%     
- Complexity     3853     5155    +1302     
============================================
  Files           151      166      +15     
  Lines         10199    12954    +2755     
============================================
+ Hits           8535    10994    +2459     
- Misses         1664     1960     +296
Impacted Files Coverage Δ Complexity Δ
src/Util/Log/JUnit.php 90.32% <100%> (+0.32%) 34 <0> (ø) ⬇️
src/Runner/StandardTestSuiteLoader.php 54.66% <0%> (-12.91%) 27% <0%> (+16%)
src/Framework/MockObject/Invocation.php 87.37% <0%> (-2.9%) 52% <0%> (+22%)
.../Framework/MockObject/Builder/InvocationMocker.php 92% <0%> (-1.75%) 50% <0%> (+17%)
src/Util/Printer.php 49.15% <0%> (-0.85%) 33% <0%> (+13%)
src/Runner/TestSuiteSorter.php 100% <0%> (ø) 71% <0%> (+10%) ⬆️
src/Framework/TestBuilder.php 100% <0%> (ø) 41% <0%> (+15%) ⬆️
src/Framework/TestSuiteIterator.php 100% <0%> (ø) 11% <0%> (ø) ⬇️
src/Util/XdebugFilterScriptGenerator.php 100% <0%> (ø) 7% <0%> (ø) ⬇️
...rc/Framework/MockObject/Matcher/InvokedAtIndex.php 57.14% <0%> (ø) 6% <0%> (?)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5558a8c...c3cc86c. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit ffc9e37 into sebastianbergmann:8.4 Oct 28, 2019
@DanielRuf DanielRuf deleted the feature/3793-junit-reporter-testsuite-warnings branch October 28, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants