Fix Psalm assertions on assertInstanceOf() #4509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 8.5 #4509 +/- ##
=========================================
Coverage 84.31% 84.31%
Complexity 3938 3938
=========================================
Files 154 154
Lines 9789 9789
=========================================
Hits 8254 8254
Misses 1535 1535
Continue to review full report at Codecov.
|
|
Well that was fast. Thanks! |
|
FYI equality assertions are documented here: https://psalm.dev/docs/annotating_code/assertion_syntax/#equality-assertions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, according to vimeo/psalm#4473 (comment), the psalm assertions should be
@psalm-assert =Tinstead of@psalm-assert T.The linked issue describes the problem in more detail.