Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more garbage collector details to event telemetry #5431

Closed

Conversation

sebastianbergmann
Copy link
Owner

@sebastianbergmann sebastianbergmann commented Jun 27, 2023

Requires php/php-src#11523 to work.

@sebastianbergmann sebastianbergmann added type/enhancement A new idea that should be implemented feature/events Issues related to PHPUnit's event system labels Jun 27, 2023
@sebastianbergmann sebastianbergmann added this to the PHPUnit 10.3 milestone Jun 27, 2023
@sebastianbergmann sebastianbergmann self-assigned this Jun 27, 2023
@sebastianbergmann sebastianbergmann force-pushed the event-telemetry-time-spent-collecting-garbage branch 2 times, most recently from ba90e5b to 7a30ae4 Compare June 27, 2023 12:13
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #5431 (c9f5e87) into main (3594a2d) will decrease coverage by 0.03%.
The diff coverage is 78.37%.

@@             Coverage Diff              @@
##               main    #5431      +/-   ##
============================================
- Coverage     86.69%   86.67%   -0.03%     
- Complexity     6162     6170       +8     
============================================
  Files           652      652              
  Lines         19607    19635      +28     
============================================
+ Hits          16999    17019      +20     
- Misses         2608     2616       +8     
Impacted Files Coverage Δ
.../Telemetry/Php83GarbageCollectorStatusProvider.php 0.00% <0.00%> (ø)
...c/Event/Value/Telemetry/GarbageCollectorStatus.php 92.72% <86.20%> (-7.28%) ⬇️
.../Telemetry/Php81GarbageCollectorStatusProvider.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sebastianbergmann sebastianbergmann force-pushed the event-telemetry-time-spent-collecting-garbage branch from 7a30ae4 to 0450a85 Compare June 28, 2023 06:19
@sebastianbergmann sebastianbergmann force-pushed the event-telemetry-time-spent-collecting-garbage branch from 0450a85 to 4514579 Compare July 10, 2023 06:10
@sebastianbergmann sebastianbergmann marked this pull request as ready for review July 16, 2023 11:24
@sebastianbergmann sebastianbergmann force-pushed the event-telemetry-time-spent-collecting-garbage branch from 4514579 to e5fdf77 Compare July 16, 2023 11:32
@sebastianbergmann sebastianbergmann force-pushed the event-telemetry-time-spent-collecting-garbage branch from e5fdf77 to c9f5e87 Compare July 18, 2023 04:35
@sebastianbergmann sebastianbergmann deleted the event-telemetry-time-spent-collecting-garbage branch July 18, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/events Issues related to PHPUnit's event system type/enhancement A new idea that should be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant