Fixed the way PHPUnit_Util_Configuration parses listener constructor arguments #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arguments Previously, getListenerConfiguration assumed the <arguments> element would always be the second element (index 1) because nicely formatted XML has a DOMText node containing a newline and some space before the arguments node. Computer-generated XML places the arguments element immediately after the listener element, so the node would be at index 0, causing the arguments node to not be found. Instead, it now searches the entire listener node for argument nodes.
sebastianbergmann
added a commit
that referenced
this pull request
Jun 22, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, getListenerConfiguration assumed the element
would always be the second element (index 1) because nicely formatted
XML has a DOMText node containing a newline and some space before the
arguments node. Computer-generated XML places the arguments element
immediately after the listener element, so the node would be at index 0,
causing the arguments node to not be found.
Instead, it now searches the entire listener node for argument nodes.