Allow markTestSkipped/Incomplete() in dataProvider

[dshafik]

• If you call $this->markTestSkipped() or
  $this->markTestIncomplete() in a dataProvider, it will now skip/incomplete
  the test, counting it as one test

[mohnishbasha]

how can i add these fixes to my current phpnit 3.7 installation ?

[whatthejeff]

Thoughts on this, @sebastianbergmann?

[szigya]

related: #1074

[whatthejeff]

Ping, @sebastianbergmann :)

/cc @jrfnl

[jrfnl]

Exactly what I was looking for! +1

[sebastianbergmann]

The pull request needs to updated (rebase, replase "3.8" with "4.3", ...). Then it should be good for merging.

[whatthejeff]

@dshafik Is this something you'll have time to do? If not, I can handle it :)

[dshafik]

Working on this now, @whatthejeff — just making sure the tests still pass and I'll update the PR

[whatthejeff]

Awesome!

[dshafik]

This is completed, the restructure of the repo threw me off on mac for a bit. Due to OS X case-insensitive FS it kept saying "phpunit" was deleted, when it meant the old PHPUnit top-level dir. Then when I did git checkout -- phpunit it would revert my changes to files in PHPUnit/Framework which needed to be moved to src/Framework and then I had new tests in Tests\* which conflicts with the new tests.

Any way, all fixed, tests for my additions pass, but there are failures. I checked with HEAD^ and had the same failures.

[whatthejeff]

@dshafik Curious what the failures are. Everything passed on travis.

[dshafik]

@whatthejeff what's the best way to get that information to you? Just paste the entire output into a gist?

[whatthejeff]

@dshafik Yeah, that works for me. Also, you might want to bump the copyright years.

[dshafik]

@whatthejeff https://gist.github.com/dshafik/936f60b54a17c5e6f0f7

[dshafik]

bumped the copyright years, @whatthejeff :)

[whatthejeff]

The test failures seem to be related to the filesystem issues you were having with OS X. I can tell you that all tests pass when I do a fresh checkout on OS X.

[whatthejeff]

Thanks for your contribution, @dshafik!

[dshafik]

@whatthejeff can confirm about the failures, all is fine on a fresh checkout. Thanks for merging! :)

[jrfnl]

Thanks @dshafik for the quick update and @whatthejeff for the merge! 💕