Don't clobber null values if array_key_exists(PHP_INT_MAX, $array) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please change the commit message to be more useful? Thanks. |
|
Sorry, I used github's 'edit from the webpage' feature and didn't notice that it chose a quite unhelpful summary. |
Handle the (extremely unusual) case where the PHP_INT_MAX or PHP_INT_MAX-1 index of the array is in use, but with a null value: don't clobber the key in that case. Similarly, don't clobber null values when selecting a random place to write the array marker and key.
cscott
changed the title
|
Merged manually, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the (extremely unusual) case where the
$array[PHP_INT_MAX] = null;; don't clobber the key in that case.