Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some unicode tests #1033

Merged
merged 11 commits into from Jan 2, 2022
Merged

Fix some unicode tests #1033

merged 11 commits into from Jan 2, 2022

Conversation

sebastienros
Copy link
Owner

No description provided.

@sebastienros
Copy link
Owner Author

I believe all the ones that fail are the ones that are now fixed.

Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, one comment about tail calls support claim.

README.md Outdated
@@ -42,9 +42,9 @@ The entire execution engine was rebuild with performance in mind, in many cases
- ✔ Proxies
- ✔ Reflect
- ✔ Symbols
- Tail calls
- Tail calls (_deprecated_)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can make this claim. This would special logic in runtime and we won't currently pass the test cases. Maybe we could just state Won't be implemented.

@sebastienros sebastienros merged commit 9e8babd into main Jan 2, 2022
@sebastienros sebastienros deleted the sebros/unicode branch January 2, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants