Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some unicode tests #1033

Merged
merged 11 commits into from
Jan 2, 2022
Merged

Fix some unicode tests #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0a9234d
Fixes some unicode tests
sebastienros Dec 26, 2021
05ec3f4
Pass more unicode tests
sebastienros Jan 1, 2022
690d644
Update esprima
sebastienros Jan 2, 2022
f650b74
Remove comments
sebastienros Jan 2, 2022
229f94f
Merge branch 'main' into sebros/unicode
sebastienros Jan 2, 2022
fb03131
Move file to skipped.json
sebastienros Jan 2, 2022
185c546
Update README
sebastienros Jan 2, 2022
b68f8e1
More fixes
sebastienros Jan 2, 2022
c8635aa
Validating with package on MyGet
sebastienros Jan 2, 2022
d0584c8
Use NuGet package
sebastienros Jan 2, 2022
c4b8271
Revert tail call changes
sebastienros Jan 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 3 additions & 11 deletions Jint.Tests.Test262/Test262Test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,10 +271,6 @@ public static IEnumerable<object[]> SourceFiles(string pathPrefix, bool skipped)
skip = true;
reason = "not in spec yet";
break;
case "u180e":
skip = true;
reason = "unicode/regexp not implemented";
break;
case "regexp-match-indices":
skip = true;
reason = "regexp-match-indices not implemented";
Expand Down Expand Up @@ -323,16 +319,12 @@ public static IEnumerable<object[]> SourceFiles(string pathPrefix, bool skipped)
reason = "Esprima problem, Unexpected token *";
}

if (name.StartsWith("built-ins/RegExp/property-escapes/generated/"))
{
skip = true;
reason = "Esprima problem, Invalid regular expression";
}
// Unicode regular expressions

if (name.StartsWith("built-ins/RegExp/unicode_"))
if (name.StartsWith("built-ins/RegExp/property-escapes/generated/"))
{
skip = true;
reason = "Unicode support and its special cases need more work";
reason = "Esprima problem";
}

// Promises
Expand Down