New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Engine.SetValue(string, string?) to accept null value. #1559

Merged

lahma merged 1 commit into sebastienros:main from czema:main

Jun 1, 2023

Contributor

czema commented May 31, 2023

It is valid to pass a nullable string to SetValue. Might as well adjust the annotations to indicate that.

string? name = null;
engine.SetValue("name", name);


          Adjust Engine.SetValue(string, string?) to accept null value.

87e5d64

string? name = null;
engine.SetValue("name", name);

lahma approved these changes

View reviewed changes

Collaborator

lahma left a comment

Good catch, thank you!

lahma merged commit d4f73ae into sebastienros:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment