Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Engine.SetValue(string, string?) to accept null value. #1559

Merged
merged 1 commit into from
Jun 1, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Jint/Engine.cs
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ public Engine SetValue(string name, Delegate value)
/// <summary>
/// Registers a string value as variable.
/// </summary>
public Engine SetValue(string name, string value)
public Engine SetValue(string name, string? value)
{
return SetValue(name, value is null ? JsValue.Null : JsString.Create(value));
}
Expand Down