Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padStart and padEnd #429 #434

Merged
merged 1 commit into from Nov 10, 2017

Conversation

WestDiscGolf
Copy link
Contributor

Thought I'd have a go at another issue on the list #429

Let me know what you think :-)

@sebastienros
Copy link
Owner

It looks good. As a general rule I try to follow the specification document that provide pseudo code for the implementation. I assume you did it as I can see similarities.

Jint is supposed to follow ES5.1 only, but I have started to accept more ES6 functions as it's not breaking the contract. So what you are doing is fine. There is an es6 branch, but I am thinking of just iterating on the main dev/master branch instead and add features as they are implemented. We already parse es6 JS in dev/master after all.

@WestDiscGolf
Copy link
Contributor Author

They were based on the links in the doc comments of the methods. I found once I'd implemented them that the majority of the functionality was the same so refactored it into a common method for them both to call.

Do you require me to close this pull request and re-submit it onto the es6 branch?

@sebastienros sebastienros merged commit 15807f0 into sebastienros:dev Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants